top-level/all-packages: misc changes to support native FreeBSD#311789
Merged
SuperSandro2000 merged 3 commits intoNixOS:masterfrom May 19, 2024
Merged
top-level/all-packages: misc changes to support native FreeBSD#311789SuperSandro2000 merged 3 commits intoNixOS:masterfrom
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
Conversation
Member
Can you explain this some more? Can we not use the same libuuid implementation as on Linux? (util-linux certainly builds a subset of itself for Darwin.) |
alyssais
reviewed
May 15, 2024
Member
alyssais
left a comment
alyssais
left a comment
There was a problem hiding this comment.
This is small enough to review in a single PR, but it would still be nice if all the little independent changes in here could be separated into their own commits.
rhelmot
force-pushed
the
freebsd-minimal3/top-level/all-packages
branch
from
977ab50 to
f26d121
Compare
ofborg
bot
added
10.rebuild-darwin: 0
rhelmot
force-pushed
the
freebsd-minimal3/top-level/all-packages
branch
from
f26d121 to
8b1cefe
Compare
Contributor
Author
|
I removed the libuuid diff because I determined it was not actually needed for the stdenv. If I rediscover the thing that prompted it, I'll investigate whether util-linux can satisfy it. |
alyssais
approved these changes
May 18, 2024
wegank
added
the
12.approvals: 1
SuperSandro2000
approved these changes
May 19, 2024
SuperSandro2000
force-pushed
the
freebsd-minimal3/top-level/all-packages
branch
from
8b1cefe to
ce149eb
Compare
SuperSandro2000
force-pushed
the
freebsd-minimal3/top-level/all-packages
branch
from
ce149eb to
6b39c14
Compare
SuperSandro2000
approved these changes
May 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
part of #296581
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.